Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove calculated version for dbt-postgres dependency #850

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

We calculate the dbt-postgres version dependency based on the version of dbt-redshift. This causes issues when we want to keep dbt-postgres at a different version than dbt-redshift.

Solution

Treat dbt-postgres like any other dependency and simply hard code the pin.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Jun 21, 2024
@mikealfare mikealfare self-assigned this Jun 21, 2024
@mikealfare mikealfare requested a review from a team as a code owner June 21, 2024 16:32
@cla-bot cla-bot bot added the cla:yes label Jun 21, 2024
@mikealfare mikealfare merged commit 3e8860a into main Jun 21, 2024
37 checks passed
@mikealfare mikealfare deleted the fix-postgres-dep branch June 21, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants